Fixes for ri5cy verilator #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is already fixed by commit e23aaf7. Set the environment variable BEEBS_TIMEOUT to adjust the timeout for each test. Second comment. BEEBS has a ChangeLog, which you need to update. |
edward-jones
force-pushed
the
erj-ri5cy-fixes
branch
3 times, most recently
from
994b6e2
to
e2cddac
Compare
edward-jones
changed the title
|
I've updated this so it now contains three basic changes:
|
edward-jones
force-pushed
the
erj-ri5cy-fixes
branch
from
e2cddac
to
72c7f21
Compare
This should work more consistently than looking for a call to __internal_syscall, which was very library specific. testsuite/ChangeLog: * config/ri5cyverilator.exp (beebs_load): Check for _exit breakpoint instead of __internal_syscall when trying to detect exit.
ChangeLog: * config/riscv32/chips/ri5cy/chip.cfg: Change CHIP_CFLAGS to match architecture of ri5cy (-march=rv32imc -mabi=ilp32)
This allows an alternative gdbserver command to be used when running the tests. testsuite/ChangeLog: * config/ri5cyverilator.exp (beebs_load): Pick up GDBSERVER_CMD environment variable if set.
edward-jones
force-pushed
the
erj-ri5cy-fixes
branch
from
72c7f21
to
75c94b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to run ri5cy using the upstream gdb and newlib I found that the tester would fail to detect the _exit breakpoint, causing all of the benchmarks to timeout.